-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 #589
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Oracle has also backported JDK-8321812. I think it would be better to backport that one first to reduce merge conflicts. I've created #594. Please take a look. |
|
/integrate |
Going to push as commit a0376cd.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit a0376cd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 21.0.5-oracle.
This PR contains a backport of
openjdk/jdk@5045839
Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit
openjdk/jdk@1d1cd32
, I ignored this commits and only change code for this issue.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/589/head:pull/589
$ git checkout pull/589
Update a local copy of the PR:
$ git checkout pull/589
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/589/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 589
View PR using the GUI difftool:
$ git pr show -t 589
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/589.diff
Webrev
Link to Webrev Comment