Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 #589

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented May 20, 2024

I backport this for parity with 21.0.5-oracle.
This PR contains a backport of
openjdk/jdk@5045839
Patch is not clean, this file test/hotspot/jtreg/gc/g1/TestHumongousAllocConcurrentStart.java has changed by the commit
openjdk/jdk@1d1cd32
, I ignored this commits and only change code for this issue.


Progress

  • JDK-8323635 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/589/head:pull/589
$ git checkout pull/589

Update a local copy of the PR:
$ git checkout pull/589
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 589

View PR using the GUI difftool:
$ git pr show -t 589

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/589.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5045839cb2095105a5c6c9eebc633a78b1e3213e 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3 May 20, 2024
@openjdk
Copy link

openjdk bot commented May 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 20, 2024
@mlbridge
Copy link

mlbridge bot commented May 20, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented May 21, 2024

Oracle has also backported JDK-8321812. I think it would be better to backport that one first to reduce merge conflicts. I've created #594. Please take a look.

@openjdk openjdk bot added the clean label May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 27, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit a0376cd.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 58c19a6: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@luchenlin Pushed as commit a0376cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants