Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330464: hserr generic events - add entry for the before_exit calls #593

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 21, 2024


Progress

  • JDK-8330464 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8330464: hserr generic events - add entry for the before_exit calls (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/593/head:pull/593
$ git checkout pull/593

Update a local copy of the PR:
$ git checkout pull/593
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 593

View PR using the GUI difftool:
$ git pr show -t 593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/593.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 21, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330464: hserr generic events - add entry for the before_exit calls

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • acff39d: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • a1e0c5d: 8332253: Linux arm32 build fails after 8292591
  • 8ff8163: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 45ed97f15b96071e5d6b6d21e8f0129eda5aa447 8330464: hserr generic events - add entry for the before_exit calls May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 21, 2024
@mlbridge
Copy link

mlbridge bot commented May 21, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 23, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2024

Going to push as commit d986096.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 20da646: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • 9035981: 8321812: Update GC tests to use execute[Limited]TestJava
  • a4d2a5a: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • 201e663: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • fe4a2ae: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • cdfe2f4: 8329840: Fix ZPhysicalMemorySegment::_end type
  • acff39d: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • a1e0c5d: 8332253: Linux arm32 build fails after 8292591
  • 8ff8163: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2024
@openjdk openjdk bot closed this May 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@MBaesken Pushed as commit d986096.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant