-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321812: Update GC tests to use execute[Limited]TestJava #594
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
test/hotspot/jtreg/gc/testlibrary/Helpers.java first hunk throws Exception now (not IOException) see javadoc ; but this is wrong already in the original change not the backport so a separate JBS issue should be filed . |
|
/approval request This GC test cleanup change has been backported to 21.0.5-oracle. We should have it in order to reduce merge conflicts with other backports. It only touches test files and the change is simple, but changes many files. Most of it applies cleanly and the PR with a few manual integrations has been reviewed. Tier 1-4 tests have passed. |
@TheRealMDoerr |
/integrate |
Going to push as commit 9035981.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 9035981. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mostly clean backport of JDK-8321812.
Manual integration was needed in the following files, but trivial to resolve:
test/hotspot/jtreg/gc/arguments/TestSmallInitialHeapWithLargePageAndNUMA.java
test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java
test/hotspot/jtreg/gc/g1/TestGCLogMessages.java
test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java
test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java
TestAllocationFailure.java was renamed from TestEvacuationFailure.java by JDK-8319313.
Skipped hunks which belong to openjdk/jdk@38cfb22 (not in 21).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/594/head:pull/594
$ git checkout pull/594
Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/594/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 594
View PR using the GUI difftool:
$ git pr show -t 594
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/594.diff
Webrev
Link to Webrev Comment