Skip to content

8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 23, 2024

Hi all,
This clean backport of JDK-8332490, to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332490 needs maintainer approval

Issue

  • JDK-8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/596/head:pull/596
$ git checkout pull/596

Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 596

View PR using the GUI difftool:
$ git pr show -t 596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/596.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon
  • 60402f8: 8330275: Crash in XMark::follow_array
  • 2e327a9: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • a0376cd: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
  • 58c19a6: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 4b1d95c: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d986096: 8330464: hserr generic events - add entry for the before_exit calls
  • 20da646: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/a1e0c5db7407bc7d58aa55f64e3f813f2eccc6ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 98f6a80852383dcbdad7292b7d269a8547d54d45 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport which try to close the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@sendaoYan
8332490: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 23, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@sendaoYan
Your change (at version d3a76f6) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 29, 2024

Going to push as commit 171a4c6.
Since your change was applied there have been 16 commits pushed to the master branch:

  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon
  • 60402f8: 8330275: Crash in XMark::follow_array
  • 2e327a9: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • a0376cd: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
  • 58c19a6: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 4b1d95c: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d986096: 8330464: hserr generic events - add entry for the before_exit calls
  • 20da646: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/a1e0c5db7407bc7d58aa55f64e3f813f2eccc6ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2024
@openjdk openjdk bot closed this May 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@RealCLanger @sendaoYan Pushed as commit 171a4c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants