-
Notifications
You must be signed in to change notification settings - Fork 129
8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport which try to close the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk. |
@sendaoYan |
Thanks for the approved. |
@sendaoYan |
/sponsor |
Going to push as commit 171a4c6.
Your commit was automatically rebased without conflicts. |
@RealCLanger @sendaoYan Pushed as commit 171a4c6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks. |
Hi all,
This clean backport of JDK-8332490, to closes the InflaterInputStream when the reads complete. The change has been verified. Only change the JMH testcase, no risk.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/596/head:pull/596
$ git checkout pull/596
Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/596/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 596
View PR using the GUI difftool:
$ git pr show -t 596
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/596.diff
Webrev
Link to Webrev Comment