-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295111: dpkg appears to have problems resolving symbolically linked native libraries #601
Conversation
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
@vpa1977 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request |
|
/integrate |
/sponsor |
@RealCLanger @vpa1977 Pushed as commit 58c19a6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 32946e18 from the openjdk/jdk repository.
The commit being backported was authored by Alexey Semenyuk on 18 Apr 2024 and was reviewed by Alexander Matveev.
This change fixes an issue caused by usrmerge on Debian-based systems - dpkg -S does not return a package containing a symlinked shared library in /lib, e.g.
The fix calls toRealPath() to resolve an actual path to the file before dpkg call and falls back to the old behaviour if the dpkg call fails.
The change is tested by jpackage set of jtreg tests and should be low risk.
jpackage tests pass:
Thanks !!!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/601/head:pull/601
$ git checkout pull/601
Update a local copy of the PR:
$ git checkout pull/601
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/601/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 601
View PR using the GUI difftool:
$ git pr show -t 601
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/601.diff
Webrev
Link to Webrev Comment