Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311666: Disabled tests in test/jdk/sun/java2d/marlin #603

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 24, 2024

Hi all,

This pull request contains a backport of commit b285ed72 from the openjdk/jdk repository.

The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8311666 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311666: Disabled tests in test/jdk/sun/java2d/marlin (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/603/head:pull/603
$ git checkout pull/603

Update a local copy of the PR:
$ git checkout pull/603
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 603

View PR using the GUI difftool:
$ git pr show -t 603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/603.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311666: Disabled tests in test/jdk/sun/java2d/marlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon
  • 60402f8: 8330275: Crash in XMark::follow_array
  • 2e327a9: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • a0376cd: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
  • 58c19a6: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b285ed72aebe2d802fa9c071372cea6c09870b9a 8311666: Disabled tests in test/jdk/sun/java2d/marlin May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 28, 2024 22:50
@openjdk
Copy link

openjdk bot commented May 28, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 29, 2024
@mrserb
Copy link
Member Author

mrserb commented May 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2024

Going to push as commit 87670e7.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 56fdca3: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
  • 0d0cf83: 8331746: Create a test to verify that the cmm id is not ignored
  • aa66422: 8333093: Incorrect comment in zAddress_aarch64.cpp
  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • 9fcb4cd: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 171a4c6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon
  • 60402f8: 8330275: Crash in XMark::follow_array
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/4b1d95c73ca503e18636129a77c0d6c49aae4821...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2024
@openjdk openjdk bot closed this May 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

@mrserb Pushed as commit 87670e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant