Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333093: Incorrect comment in zAddress_aarch64.cpp #613

Closed

Conversation

ashu-mehra
Copy link

@ashu-mehra ashu-mehra commented May 28, 2024

Hi all,

This pull request contains a backport of commit 51ae08f7 from the openjdk/jdk repository.

The commit being backported was authored by Ashutosh Mehra on 28 May 2024 and was reviewed by Stefan Karlsson.

It is a trivial change to fix the comments.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333093 needs maintainer approval

Issue

  • JDK-8333093: Incorrect comment in zAddress_aarch64.cpp (Bug - P5 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/613/head:pull/613
$ git checkout pull/613

Update a local copy of the PR:
$ git checkout pull/613
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 613

View PR using the GUI difftool:
$ git pr show -t 613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/613.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333093: Incorrect comment in zAddress_aarch64.cpp

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • 9fcb4cd: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 171a4c6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 51ae08f72b879bc611177ea643cd88e36185d9e8 8333093: Incorrect comment in zAddress_aarch64.cpp May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 28, 2024

⚠️ @ashu-mehra This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2024
@ashu-mehra
Copy link
Author

/approval request Backporting this patch to keep the comments in sync with mainline. Patch applies cleanly. Only comments are updated, so its a no risk change.

@openjdk
Copy link

openjdk bot commented May 28, 2024

@ashu-mehra
8333093: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 28, 2024
@mlbridge
Copy link

mlbridge bot commented May 28, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented May 29, 2024

Please create a jdk22u backport as well to keep it in sync.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 29, 2024
@ashu-mehra
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@ashu-mehra
Your change (at version f9f2433) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 29, 2024

Going to push as commit aa66422.
Since your change was applied there have been 6 commits pushed to the master branch:

  • fb7713d: 8331714: Make OopMapCache installation lock-free
  • a3b14cf: 8330576: ZYoungCompactionLimit should have range check
  • 9fcb4cd: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 171a4c6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
  • b7c7006: 8331266: Bump update version for OpenJDK: jdk-21.0.5
  • 2971cb5: 8320692: Null icon returned for .exe without custom icon

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2024
@openjdk openjdk bot closed this May 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@TheRealMDoerr @ashu-mehra Pushed as commit aa66422.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants