-
Notifications
You must be signed in to change notification settings - Fork 148
8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Thanks for the review! I don't have Ubuntu 23.04. The headful tests have passed on Ubuntu 22.04 (Power9) except MultiResolutionSplashTest. That one doesn't work on any linux with or without this patch on my X-server: "Image with wrong resolution is used for splash screen!" I'm going to ignore this unless anybody is volunteering to test it with another setup. |
|
/approval request Should get backported for parity with 21.0.5-oracle. The actual fix is small, applies cleanly and has already been shipped to customers with JDK 22. I can't test on Ubuntu 23.04 because I don't have it. Running the headful tests on other OSes didn't show any regression. |
|
@TheRealMDoerr |
|
/integrate |
|
Going to push as commit 7723611.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit 7723611. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Basically clean backport of JDK-8305825. Skipped these removals from the ProblemList because they are not problem listed in 21:
javax/swing/JTree/8003400/Test8003400.java 8309734 linux-all
javax/swing/JTable/7124218/SelectEditTableCell.java 8309734 linux-all
javax/swing/JFileChooser/JFileChooserSetLocationTest.java 8309734 linux-all
Can anybody test it on Ubuntu 23.04?
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/617/head:pull/617$ git checkout pull/617Update a local copy of the PR:
$ git checkout pull/617$ git pull https://git.openjdk.org/jdk21u-dev.git pull/617/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 617View PR using the GUI difftool:
$ git pr show -t 617Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/617.diff
Webrev
Link to Webrev Comment