Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 29, 2024

Basically clean backport of JDK-8305825. Skipped these removals from the ProblemList because they are not problem listed in 21:
javax/swing/JTree/8003400/Test8003400.java 8309734 linux-all
javax/swing/JTable/7124218/SelectEditTableCell.java 8309734 linux-all
javax/swing/JFileChooser/JFileChooserSetLocationTest.java 8309734 linux-all

Can anybody test it on Ubuntu 23.04?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8305825 needs maintainer approval

Issue

  • JDK-8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/617/head:pull/617
$ git checkout pull/617

Update a local copy of the PR:
$ git checkout pull/617
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 617

View PR using the GUI difftool:
$ git pr show -t 617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/617.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 29, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 0e9b9f2: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • 0d9833e: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • 0dcbc1d: 8324668: JDWP process management needs more efficient file descriptor handling
  • 42e6a97: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • 55e97ce: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • b56f0c0: 8326106: Write and clear stack trace table outside of safepoint
  • 8d4f686: 8312229: Crash involving yield, switch and anonymous classes
  • 2a21044: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • 362ecac: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/aa66422e3acc804e85f3b0dd6662f75040004a96...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 632a3c56e0626b4c4f79c8cb3d2ae312668d63fc 8305825: getBounds API returns wrong value resulting in multiple Regression Test Failures on Ubuntu 23.04 May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 29, 2024
@mlbridge
Copy link

mlbridge bot commented May 29, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented May 30, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented May 30, 2024

Thanks for the review! I don't have Ubuntu 23.04. The headful tests have passed on Ubuntu 22.04 (Power9) except MultiResolutionSplashTest. That one doesn't work on any linux with or without this patch on my X-server: "Image with wrong resolution is used for splash screen!" I'm going to ignore this unless anybody is volunteering to test it with another setup.

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 21.0.5-oracle. The actual fix is small, applies cleanly and has already been shipped to customers with JDK 22. I can't test on Ubuntu 23.04 because I don't have it. Running the headful tests on other OSes didn't show any regression.

@openjdk
Copy link

openjdk bot commented May 31, 2024

@TheRealMDoerr
8305825: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 31, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 1, 2024

Going to push as commit 7723611.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 0e9b9f2: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • 0d9833e: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • 0dcbc1d: 8324668: JDWP process management needs more efficient file descriptor handling
  • 42e6a97: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • 55e97ce: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • b56f0c0: 8326106: Write and clear stack trace table outside of safepoint
  • 8d4f686: 8312229: Crash involving yield, switch and anonymous classes
  • 2a21044: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • 362ecac: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/aa66422e3acc804e85f3b0dd6662f75040004a96...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 1, 2024
@openjdk openjdk bot closed this Jun 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 1, 2024
@openjdk
Copy link

openjdk bot commented Jun 1, 2024

@TheRealMDoerr Pushed as commit 7723611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8305825_X11 branch June 1, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants