Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ #622

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 30, 2024

Hi all,

This pull request contains a backport of commit eb60822a from the openjdk/jdk repository.

The commit being backported was authored by Abhishek Kumar on 19 Apr 2024 and was reviewed by Damon Nguyen, Jayathirth D V, Tejesh R and Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310072 needs maintainer approval

Issue

  • JDK-8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/622/head:pull/622
$ git checkout pull/622

Update a local copy of the PR:
$ git checkout pull/622
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 622

View PR using the GUI difftool:
$ git pr show -t 622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/622.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 0d9833e: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • 0dcbc1d: 8324668: JDWP process management needs more efficient file descriptor handling
  • 42e6a97: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • 55e97ce: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • b56f0c0: 8326106: Write and clear stack trace table outside of safepoint
  • 8d4f686: 8312229: Crash involving yield, switch and anonymous classes
  • 2a21044: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • 362ecac: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport eb60822a45ecd076484e707b2dd1049ed9d8079b 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+ May 30, 2024
@openjdk
Copy link

openjdk bot commented May 30, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 30, 2024 07:08
@openjdk
Copy link

openjdk bot commented May 30, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels May 30, 2024
@mlbridge
Copy link

mlbridge bot commented May 30, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 31, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 1, 2024

Going to push as commit 0e9b9f2.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 0d9833e: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • 0dcbc1d: 8324668: JDWP process management needs more efficient file descriptor handling
  • 42e6a97: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • 55e97ce: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
  • b56f0c0: 8326106: Write and clear stack trace table outside of safepoint
  • 8d4f686: 8312229: Crash involving yield, switch and anonymous classes
  • 2a21044: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • 362ecac: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
  • dc8b95f: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 1, 2024
@openjdk openjdk bot closed this Jun 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 1, 2024
@openjdk
Copy link

openjdk bot commented Jun 1, 2024

@mrserb Pushed as commit 0e9b9f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant