8332154: Memory leak in SynchronousQueue

[shipilev]

Resolves the memory leak introduced in 22 and backported to 21.0.2.

Additional testing:

• Linux x86_64 server fastdebug, all
• Linux AArch64 server fastdebug, all

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8332154 needs maintainer approval

Issue

• JDK-8332154: Memory leak in SynchronousQueue (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/624/head:pull/624
$ git checkout pull/624

Update a local copy of the PR:
$ git checkout pull/624
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 624

View PR using the GUI difftool:
$ git pr show -t 624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/624.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332154: Memory leak in SynchronousQueue

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• cdf3443: 8333477: Delete extra empty spaces in Makefiles
• c58ed6b: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
• bf9aa3c: 8332675: test/hotspot/jtreg/gc/testlibrary/Helpers.java compileClass javadoc does not match after 8321812
• aeccc4e: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
• e55dd27: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 7039562: 8287325: AArch64: fix virtual threads with -XX:UseBranchProtection=pac-ret
• 8da58b9: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a91bb643)
• 00: Full (003db447)

[shipilev]

/approval request Resolves the memory leak introduced in 22 and backported to 21.0.2. Applies cleanly, all tests pass. The change is simple, and seems to be what LinkedTransferQueue already does here: https://github.com/openjdk/jdk/blob/b25476200ab8bea4f25a671d5b9351662d11c5b4/src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java#L616-L617

[openjdk]

@shipilev
8332154: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit e7a7af0.
Since your change was applied there have been 9 commits pushed to the master branch:

• a7a11a9: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'
• e1b19ae: 8332894: ubsan: vmError.cpp:2090:26: runtime error: division by zero
• cdf3443: 8333477: Delete extra empty spaces in Makefiles
• c58ed6b: 8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
• bf9aa3c: 8332675: test/hotspot/jtreg/gc/testlibrary/Helpers.java compileClass javadoc does not match after 8321812
• aeccc4e: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
• e55dd27: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 7039562: 8287325: AArch64: fix virtual threads with -XX:UseBranchProtection=pac-ret
• 8da58b9: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit e7a7af0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.