-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325382: (fc) FileChannel.transferTo throws IOException when position equals size #631
8325382: (fc) FileChannel.transferTo throws IOException when position equals size #631
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all right to me.
|
Thanks for the review! |
/approval request Should get backported for parity with 21.0.5-oracle. Applies almost cleanly and tier 1-4 have passed. |
@TheRealMDoerr |
/integrate |
Going to push as commit e4ac1a4.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit e4ac1a4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8325382. Not clean because of indentation. Included test has passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/631/head:pull/631
$ git checkout pull/631
Update a local copy of the PR:
$ git checkout pull/631
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/631/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 631
View PR using the GUI difftool:
$ git pr show -t 631
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/631.diff
Webrev
Link to Webrev Comment