8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache

[shipilev]

Improves OopMapCache performance by skipping enqueuing when we can deallocate the entry directly. This would be even more important as we backport JDK-8331572.

Additional testing:

• Linux x86_64 server fastdebug, all

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317240 needs maintainer approval

Issue

• JDK-8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/655/head:pull/655
$ git checkout pull/655

Update a local copy of the PR:
$ git checkout pull/655
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 655

View PR using the GUI difftool:
$ git pr show -t 655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/655.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 46c0e1e: 8322008: Exclude some CDS tests from running with -Xshare:off
• f1c7553: 8310201: Reduce verbose locale output in -XshowSettings launcher option
• d51b8ea: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
• bbc8cde: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
• 9c0896c: 8315031: YoungPLABSize and OldPLABSize not aligned by ObjectAlignmentInBytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Improves OopMapCache performance, important for JDK-8331572 backport. Applies cleanly. All tests pass. Risk is on lower side: the change is simple, and there is no bug tail since original integration 8 months ago.

[openjdk]

@shipilev
8317240: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (e7abe398)

[shipilev]

/integrate

[openjdk]

Going to push as commit 78d39b1.
Since your change was applied there have been 9 commits pushed to the master branch:

• eee3b42: 8332431: NullPointerException in JTable of SwingSet2
• 82adc56: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out
• 481b42f: 8315804: Open source several Swing JTabbedPane JTextArea JTextField tests
• 53b2836: 8320945: problemlist tests failing on latest Windows 11 update
• 46c0e1e: 8322008: Exclude some CDS tests from running with -Xshare:off
• f1c7553: 8310201: Reduce verbose locale output in -XshowSettings launcher option
• d51b8ea: 8323577: C2 SuperWord: remove AlignVector restrictions on IR tests added in JDK-8305055
• bbc8cde: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
• 9c0896c: 8315031: YoungPLABSize and OldPLABSize not aligned by ObjectAlignmentInBytes

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 78d39b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.