-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332898: failure_handler: log directory of commands #657
8332898: failure_handler: log directory of commands #657
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Should get backported for parity with 21.0.5-oracle. Applies cleanly. Tier 1-4 have passed. |
@TheRealMDoerr |
/integrate |
Going to push as commit ca5fd70.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit ca5fd70. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8332898.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/657/head:pull/657
$ git checkout pull/657
Update a local copy of the PR:
$ git checkout pull/657
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/657/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 657
View PR using the GUI difftool:
$ git pr show -t 657
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/657.diff
Webrev
Link to Webrev Comment