Skip to content

8332154: Memory leak in SynchronousQueue #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 10, 2024

Clean backport of JDK-8332154.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332154 needs maintainer approval

Issue

  • JDK-8332154: Memory leak in SynchronousQueue (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/687/head:pull/687
$ git checkout pull/687

Update a local copy of the PR:
$ git checkout pull/687
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 687

View PR using the GUI difftool:
$ git pr show -t 687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/687.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b78613b6813a85662fb2af2004d0b68002fe471d 8332154: Memory leak in SynchronousQueue Jun 10, 2024
@openjdk
Copy link

openjdk bot commented Jun 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 10, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2024

Webrevs

@shipilev
Copy link
Member

Actually, already here: #624 -- and I have ran lots of test for it :)

@TheRealMDoerr
Copy link
Contributor Author

Actually, already here: #624 -- and I have ran lots of test for it :)

Thanks for testing! Please go ahead with yours and apply for approval. I'll close mine if you're faster ;-)

@shipilev
Copy link
Member

Actually, already here: #624 -- and I have ran lots of test for it :)

Thanks for testing! Please go ahead with yours and apply for approval. I'll close mine if you're faster ;-)

Done! I meant to request approval after 21.0.5-oracle backport lands. It seems it did :)

@openjdk openjdk bot added the approval label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants