Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318986: Improve GenericWaitBarrier performance #70

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 19, 2023

Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17.

Additional testing:

  • Ad-hoc performance runs, expected improvements
  • MacOS AArch64 server fastdebug, all tests

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318986 needs maintainer approval

Issue

  • JDK-8318986: Improve GenericWaitBarrier performance (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/70.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 30462f9da40d3a7ec18fcf46e2154fabb5fd4753 8318986: Improve GenericWaitBarrier performance Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

This backport pull request has now been updated with issue from the original commit.

@shipilev shipilev force-pushed the JDK-8318986-generic-wait-barrier branch from 5501b2e to 3e336a1 Compare January 30, 2024 09:52
@shipilev shipilev marked this pull request as ready for review February 1, 2024 08:21
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2024

Webrevs

@shipilev shipilev force-pushed the JDK-8318986-generic-wait-barrier branch from 3e336a1 to 98149cc Compare February 28, 2024 19:13
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shipilev
Copy link
Member Author

GHA failure in RISC-V build is infrastructural: JDK-8326960.

@shipilev
Copy link
Member Author

/approval request Clean backport to drastically improve safepoint performance under heavy load, fixing regression between JDK 11 and JDK 17. Applies cleanly. There is no bugtail in mainline since integration in Nov 2023. All tests pass. Risk is medium, as it touches the common code path for non-Linux platforms, but it is also frequently exercised, and thus a breakage would manifest often.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@shipilev
8318986: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318986: Improve GenericWaitBarrier performance

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@shipilev
Copy link
Member Author

@GoeLin, @jerboaa -- would you mind approving it for 21u? We seem to be in agreement about this plan, see the JBS comments.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 18, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

Going to push as commit 6c5500b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f0f2e70: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2024
@openjdk openjdk bot closed this Apr 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@shipilev Pushed as commit 6c5500b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8318986-generic-wait-barrier branch April 24, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant