Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails #709

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link

@amosshi amosshi commented Jun 12, 2024

Backport of JDK-7022325

  • The git patch is clean

Testing

  • Local: Test passed on MacOS 14.5
    • ReadLongZipFileName.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-06-21
    • jtreg_jdk_tier1: java/util/zip/ZipFile/ReadLongZipFileName.java: SUCCESSFUL GitHub 📊⏲ - [5,793 msec]

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-7022325 needs maintainer approval

Issue

  • JDK-7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/709/head:pull/709
$ git checkout pull/709

Update a local copy of the PR:
$ git checkout pull/709
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 709

View PR using the GUI difftool:
$ git pr show -t 709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/709.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • fe999ba: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"
  • d5363bc: 8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml
  • c3693c2: 8327840: Automate javax/swing/border/Test4129681.java
  • 6a67861: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
  • 7e12de9: 8334332: TestIOException.java fails if run by root
  • 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • c0eb17c: 8331063: Some HttpClient tests don't report leaks
  • c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
  • ... and 54 more: https://git.openjdk.org/jdk21u-dev/compare/e716aaec1295e0d378924c08d6f698ac92b2dc4e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4785461f61d8f5c7444d2e6fd90f1e083dbc6fe4 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@amosshi
Copy link
Author

amosshi commented Jun 20, 2024

/approval request "Backporting for parity with 21.0.5-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-06-21”

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@amosshi
7022325: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 20, 2024
@amosshi
Copy link
Author

amosshi commented Jun 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2024

Going to push as commit c77926c.
Since your change was applied there have been 74 commits pushed to the master branch:

  • 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
  • d2534fa: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • 420c4b5: 8316389: Open source few AWT applet tests
  • 8094990: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 2ed8a96: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • edbe6f9: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • d927a6f: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
  • d8a00da: 8315024: Vector API FP reduction tests should not test for exact equality
  • 2d89cc2: 8321933: TestCDSVMCrash.java spawns two processes
  • d0e54e9: 8241550: [macOS] SSLSocketImpl/ReuseAddr.java failed due to "BindException: Address already in use"
  • ... and 64 more: https://git.openjdk.org/jdk21u-dev/compare/e716aaec1295e0d378924c08d6f698ac92b2dc4e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2024
@openjdk openjdk bot closed this Jun 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2024
@openjdk
Copy link

openjdk bot commented Jun 23, 2024

@amosshi Pushed as commit c77926c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-7022325 branch June 23, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant