Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323122: AArch64: Increase itable stub size estimate #711

Closed
wants to merge 1 commit into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Jun 12, 2024

This is a tiny safety follow-up to JDK-8307352 (AARCH64: Improve itable_stub). Original change applies cleanly.

Testing: jtreg tier1,2 on linux-aarch64.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8323122 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8323122: AArch64: Increase itable stub size estimate (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/711/head:pull/711
$ git checkout pull/711

Update a local copy of the PR:
$ git checkout pull/711
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 711

View PR using the GUI difftool:
$ git pr show -t 711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/711.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@dchuyko This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323122: AArch64: Increase itable stub size estimate

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 622026a: 8316756: C2 EA fails with "missing memory path" when encountering unsafe_arraycopy stub call
  • 807a4b6: 8324174: assert(m->is_entered(current)) failed: invariant
  • 03facb9: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
  • 4cd947b: 8327423: C2 remove_main_post_loops: check if main-loop belongs to pre-loop, not just assert
  • ea2aa9e: 8324969: C2: prevent elimination of unbalanced coarsened locking regions
  • fa896c7: 8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure
  • 9dca67b: 8332959: C2: ZGC fails with 'Incorrect load shift' when invoking Object.clone() reflectively on an array
  • 6a83392: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
  • d13f75c: 8331863: DUIterator_Fast used before it is constructed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 36f4b34f1953af736706ec67192204727808bc6c 8323122: AArch64: Increase itable stub size estimate Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

⚠️ @dchuyko This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@dchuyko
Copy link
Member Author

dchuyko commented Jun 12, 2024

/approval request This is a tiny follow-up to JDK-8307352 (AARCH64: Improve itable_stub) backport. The estimate is raised a bit for safety. Original change applies cleanly after the leading backport.

Testing: jtreg tier1,2 on linux-aarch64.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@dchuyko
8323122: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 12, 2024
@dchuyko
Copy link
Member Author

dchuyko commented Jun 13, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@dchuyko
Your change (at version acb486b) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 13, 2024

Going to push as commit 1831a95.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 622026a: 8316756: C2 EA fails with "missing memory path" when encountering unsafe_arraycopy stub call
  • 807a4b6: 8324174: assert(m->is_entered(current)) failed: invariant
  • 03facb9: 8332905: C2 SuperWord: bad AD file, with RotateRightV and first operand not a pack
  • 4cd947b: 8327423: C2 remove_main_post_loops: check if main-loop belongs to pre-loop, not just assert
  • ea2aa9e: 8324969: C2: prevent elimination of unbalanced coarsened locking regions
  • fa896c7: 8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure
  • 9dca67b: 8332959: C2: ZGC fails with 'Incorrect load shift' when invoking Object.clone() reflectively on an array
  • 6a83392: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
  • d13f75c: 8331863: DUIterator_Fast used before it is constructed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2024
@openjdk openjdk bot closed this Jun 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 13, 2024
@openjdk
Copy link

openjdk bot commented Jun 13, 2024

@TheRealMDoerr @dchuyko Pushed as commit 1831a95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants