Skip to content

Conversation

@luchenlin
Copy link

@luchenlin luchenlin commented Jun 14, 2024

I backport this for parity with 21.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8317635 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8317635: Improve GetClassFields test to verify correctness of field order (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/721/head:pull/721
$ git checkout pull/721

Update a local copy of the PR:
$ git checkout pull/721
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 721

View PR using the GUI difftool:
$ git pr show -t 721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/721.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317635: Improve GetClassFields test to verify correctness of field order

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • c08de56: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • 762e983: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
  • 8cb3b1f: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 710a0b0: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 28c16d4: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 8ca5280: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity
  • d2f857a: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
  • 9a392ea: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • dba6716: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
  • df03054: 8319793: C2 compilation fails with "Bad graph detected in build_loop_late" after JDK-8279888
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/ccfae880577ab5b071815de13474e8987b45c943...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 599560a832386d9c61aca24450d6efa65156f663 8317635: Improve GetClassFields test to verify correctness of field order Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 17, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit 71a035a.
Since your change was applied there have been 13 commits pushed to the master branch:

  • a30e9c6: 8318071: IgnoreUnrecognizedVMOptions flag still causes failure in ArchiveHeapTestClass
  • a1e43d9: 8323274: C2: array load may float above range check
  • c08de56: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • 762e983: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
  • 8cb3b1f: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 710a0b0: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 28c16d4: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
  • 8ca5280: 8322996: BoxLockNode creation fails with assert(reg < CHUNK_SIZE) failed: sanity
  • d2f857a: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
  • 9a392ea: 8323972: C2 compilation fails with assert(!x->as_Loop()->is_loop_nest_inner_loop()) failed: loop was transformed
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/ccfae880577ab5b071815de13474e8987b45c943...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@luchenlin Pushed as commit 71a035a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant