8308660: C2 compilation hits 'node must be dead' assert

[TheRealMDoerr]

Backport of JDK-8308660. Basically clean. Only indentation is different. Please review!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8308660 needs maintainer approval

Issue

• JDK-8308660: C2 compilation hits 'node must be dead' assert (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/729/head:pull/729
$ git checkout pull/729

Update a local copy of the PR:
$ git checkout pull/729
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 729

View PR using the GUI difftool:
$ git pr show -t 729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/729.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308660: C2 compilation hits 'node must be dead' assert

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• fcd7fb7: 8331142: Add test for number of loader threads in BasicDirectoryModel
• 686d69d: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• aeae521: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• b0894f2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
• 7cf4272: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
• 71a035a: 8317635: Improve GetClassFields test to verify correctness of field order
• a30e9c6: 8318071: IgnoreUnrecognizedVMOptions flag still causes failure in ArchiveHeapTestClass
• a1e43d9: 8323274: C2: array load may float above range check
• c08de56: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
• 762e983: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string
• ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/df030542eb11bb3482e2a8c7c8a477a333a409c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (3fa119d5)

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TheRealMDoerr]

Thanks for the review!

[TheRealMDoerr]

/approval request Should get backported for parity with 21.0.5-oracle. Applies almost cleanly, has been reviewed and tier 1-4 have passed.

[openjdk]

@TheRealMDoerr
8308660: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit ef30dbc.
Since your change was applied there have been 19 commits pushed to the master branch:

• 4af7862: 8322743: C2: prevent lock region elimination in OSR compilation
• a5eb7f2: 8329088: Stack chunk thawing races with concurrent GC stack iteration
• fcd7fb7: 8331142: Add test for number of loader threads in BasicDirectoryModel
• 686d69d: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
• aeae521: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• b0894f2: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
• 7cf4272: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
• 71a035a: 8317635: Improve GetClassFields test to verify correctness of field order
• a30e9c6: 8318071: IgnoreUnrecognizedVMOptions flag still causes failure in ArchiveHeapTestClass
• a1e43d9: 8323274: C2: array load may float above range check
• ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/df030542eb11bb3482e2a8c7c8a477a333a409c8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit ef30dbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.