Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml #732

Closed
wants to merge 1 commit into from
Closed

8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml #732

wants to merge 1 commit into from

Conversation

fitzsim
Copy link
Contributor

@fitzsim fitzsim commented Jun 17, 2024 •
edited by openjdk bot
Loading

This is a backport request for 8332174, which is not yet maintainer-approved.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8332174 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/732/head:pull/732
$ git checkout pull/732

Update a local copy of the PR:
$ git checkout pull/732
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 732

View PR using the GUI difftool:
$ git pr show -t 732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/732.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back fitzsim! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024 •
edited
Loading

@fitzsim This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • c3693c2: 8327840: Automate javax/swing/border/Test4129681.java
  • 6a67861: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
  • 7e12de9: 8334332: TestIOException.java fails if run by root
  • 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • c0eb17c: 8331063: Some HttpClient tests don't report leaks
  • c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
  • 568bd67: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
  • 8148675: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/fcd7fb74c7654956660082c83e42d2262478a1e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

⚠️ @fitzsim could not find any commit with hash 4910826e52eb39d2a3dea22c886d0b1577e14bf3. Please update the title with the hash for an existing commit.

@fitzsim fitzsim mentioned this pull request Jun 17, 2024
Open
4 tasks
@fitzsim fitzsim changed the title Backport 4910826e52eb39d2a3dea22c886d0b1577e14bf3 8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml Jun 17, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 17, 2024

(re-using this backport-attempt PR; if it gets too messy I can delete this an re-create it.)

This is a partial backport of the CLDR 45.0 update. Specifically, it brings this upstream CLDR change to ff_Adlm.xml to 21u: https://patch-diff.githubusercontent.com/raw/unicode-org/cldr/pull/3606.patch

I filed a request for the same patch in 22u, but it might be too late for that: openjdk/jdk22u#223

gnu-andrew
gnu-andrew approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this matches the 22u patch, which in turn, matches the part of the upstream patch which alters the code under common.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

⚠️ @fitzsim This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 19, 2024

Thank you, @gnu-andrew.

/approval

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@fitzsim usage: /approval [<id>] (request|cancel) [<text>]

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 19, 2024

/approval

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@fitzsim usage: /approval [<id>] (request|cancel) [<text>]

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 19, 2024

/approval 8332174 request This one is ready to go into jdk21u-dev.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@fitzsim
8332174: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 19, 2024
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@gnu-andrew
8332174: The approval request has been approved.

@fitzsim
Copy link
Contributor Author

fitzsim commented Jun 20, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@fitzsim
Your change (at version bf05b90) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

Going to push as commit d5363bc.
Since your change was applied there have been 19 commits pushed to the master branch:

  • c3693c2: 8327840: Automate javax/swing/border/Test4129681.java
  • 6a67861: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
  • 7e12de9: 8334332: TestIOException.java fails if run by root
  • 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • c0eb17c: 8331063: Some HttpClient tests don't report leaks
  • c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
  • 568bd67: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
  • 8148675: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/fcd7fb74c7654956660082c83e42d2262478a1e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2024
@openjdk openjdk bot closed this Jun 21, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jun 21, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@gnu-andrew @fitzsim Pushed as commit d5363bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnu-andrew gnu-andrew gnu-andrew approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzsim @gnu-andrew