Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322743: C2: prevent lock region elimination in OSR compilation #733

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 17, 2024

Clean backport of JDK-8322743.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8322743 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8322743: C2: prevent lock region elimination in OSR compilation (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/733/head:pull/733
$ git checkout pull/733

Update a local copy of the PR:
$ git checkout pull/733
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 733

View PR using the GUI difftool:
$ git pr show -t 733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/733.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322743: C2: prevent lock region elimination in OSR compilation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 742c776a922bc226a3beaa9e219ff0bd2baf7bc4 8322743: C2: prevent lock region elimination in OSR compilation Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 21.0.5-oracle. Applies cleanly and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@TheRealMDoerr
8322743: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 18, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

Going to push as commit 4af7862.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a5eb7f2: 8329088: Stack chunk thawing races with concurrent GC stack iteration

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 18, 2024
@openjdk openjdk bot closed this Jun 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@TheRealMDoerr Pushed as commit 4af7862.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant