-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections #735
Conversation
👋 Welcome back neethu-prasad! A progress list of the required criteria for merging this PR into |
@neethu-prasad This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Backport to unlink 'ConditionNode' before they are transferred to the sync queue; applies cleanly; All tests passed; Risk is low: there are no follow-up bug since mainline integration 4 months ago. Also, similar change was made to LinkedBlockingQueue more than 10 years ago as part of JDK-6805775 |
@neethu-prasad |
Thanks for the review & approval. /integrate |
@neethu-prasad |
/sponsor |
Going to push as commit 241b054.
Your commit was automatically rebased without conflicts. |
@RealCLanger @neethu-prasad Pushed as commit 241b054. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Notes
Backport of JDK-8325754.
Unlink 'ConditionNode' before they are transferred to the sync queue as G1 seems to be able to collect “dead” ConditionNode instances during minor collections only if no formerly alive ConditionNode instances were promoted to the old generation and died there, which often cannot be avoided since e.g. on application startup many objects are promoted to the old generation after a few collections.
Verification
Before PR
After this change
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/735/head:pull/735
$ git checkout pull/735
Update a local copy of the PR:
$ git checkout pull/735
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/735/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 735
View PR using the GUI difftool:
$ git pr show -t 735
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/735.diff
Webrev
Link to Webrev Comment