8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines

[neethu-prasad]

Notes

Backport of JDK-8317360

Verification

• jdk_jfr, Tier1 & Tier 2 tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317360 needs maintainer approval

Issue

• JDK-8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/737/head:pull/737
$ git checkout pull/737

Update a local copy of the PR:
$ git checkout pull/737
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 737

View PR using the GUI difftool:
$ git pr show -t 737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/737.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back neethu-prasad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@neethu-prasad This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• c3693c2: 8327840: Automate javax/swing/border/Test4129681.java
• 6a67861: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
• 7e12de9: 8334332: TestIOException.java fails if run by root
• 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
• c0eb17c: 8331063: Some HttpClient tests don't report leaks
• c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
• 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 568bd67: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
• 8148675: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
• ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/fcd7fb74c7654956660082c83e42d2262478a1e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @neethu-prasad This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (dd179d98)

[neethu-prasad]

/approval request Backport to fix missing null checks in JfrCheckpointManager and JfrStringPool initialization routines; applies cleanly; All tests passed; Risk is low as the code change is minimal i.e; adding null check.

[openjdk]

@neethu-prasad
8317360: The approval request has been created successfully.

[neethu-prasad]

Thanks for the review & approval.

/integrate

[openjdk]

@neethu-prasad
Your change (at version dd179d9) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 1c19bbd.
Since your change was applied there have been 34 commits pushed to the master branch:

• 432144b: 8316211: Open source several manual applet tests
• a045d78: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
• c77926c: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
• 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
• d2534fa: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
• 420c4b5: 8316389: Open source few AWT applet tests
• 8094990: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
• 2ed8a96: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• edbe6f9: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• d927a6f: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
• ... and 24 more: https://git.openjdk.org/jdk21u-dev/compare/fcd7fb74c7654956660082c83e42d2262478a1e5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @neethu-prasad Pushed as commit 1c19bbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.