8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop

[TheRealMDoerr]

Backport of JDK-8330819. Doesn't apply cleanly. The fix needs to be integrated into a different file, because JDK-8312332 is not in 21u. In addition, --enable-preview needs to get added in the test (see 2nd commit). Please review.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8330819 needs maintainer approval

Issue

• JDK-8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/744/head:pull/744
$ git checkout pull/744

Update a local copy of the PR:
$ git checkout pull/744
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/744/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 744

View PR using the GUI difftool:
$ git pr show -t 744

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/744.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 4f8917e: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
• 6cd06d7: 8320079: The ArabicBox.java test has no control buttons
• 943e759: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 2e8418e: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (ce94cb0a)

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TheRealMDoerr]

Thanks for the review!

[TheRealMDoerr]

/approval request Should get backported for parity with 21.0.5-oracle. The backport has been reviewed and tier 1-4 have passed.

[openjdk]

@TheRealMDoerr
8330819: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 8148675.
Since your change was applied there have been 5 commits pushed to the master branch:

• 0272ae0: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
• 4f8917e: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
• 6cd06d7: 8320079: The ArabicBox.java test has no control buttons
• 943e759: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 2e8418e: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 8148675.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.