Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests #746

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Jun 18, 2024

Clean backport to unblock parallelism vmTestbase/nsk/stress/stack tests.
GHA tested.
Command below succeeded
make test TEST=vmTestbase/nsk/stress/stack JTREG=REPEAT_COUNT=100


Progress

  • JDK-8318605 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/746/head:pull/746
$ git checkout pull/746

Update a local copy of the PR:
$ git checkout pull/746
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 746

View PR using the GUI difftool:
$ git pr show -t 746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/746.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
  • 7e12de9: 8334332: TestIOException.java fails if run by root
  • 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • c0eb17c: 8331063: Some HttpClient tests don't report leaks
  • c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
  • 568bd67: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
  • 8148675: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • 0272ae0: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
  • 4f8917e: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • ... and 24 more: https://git.openjdk.org/jdk21u-dev/compare/df030542eb11bb3482e2a8c7c8a477a333a409c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d9aa1deac8474f87dd867809f7265b9496917c6f 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval JDK-8318605 request to unblock parallelism vmTestbase/nsk/stress/stack tests.
GHA tested. Low risk. GHA tested

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@elifaslan1
JDK-8318605: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 18, 2024
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@elifaslan1
Your change (at version de4d888) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

Going to push as commit 6a67861.
Since your change was applied there have been 34 commits pushed to the master branch:

  • a79db00: 8309685: Fix -Wconversion warnings in assembler and register code
  • 7e12de9: 8334332: TestIOException.java fails if run by root
  • 5c1282b: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • c0eb17c: 8331063: Some HttpClient tests don't report leaks
  • c959207: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
  • 4bb85fc: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
  • 568bd67: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
  • 8148675: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • 0272ae0: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
  • 4f8917e: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • ... and 24 more: https://git.openjdk.org/jdk21u-dev/compare/df030542eb11bb3482e2a8c7c8a477a333a409c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2024
@openjdk openjdk bot closed this Jun 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@shipilev @elifaslan1 Pushed as commit 6a67861.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants