Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320206: Some intrinsics/stubs missing vzeroupper on x86_64 #75

Closed

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Dec 19, 2023


Progress

  • JDK-8320206 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320206: Some intrinsics/stubs missing vzeroupper on x86_64 (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/75.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b372e28ceb8b054118027626eb454b8a493740b 8320206: Some intrinsics/stubs missing vzeroupper on x86_64 Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

⚠️ @sviswa7 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2023
@sviswa7
Copy link
Author

sviswa7 commented Dec 19, 2023

/approval request This is a clean backport and not dependent on any other backport.,
A very small patch with changes to emit missing vzeroupper instructions at select locations to avoid AVX->SSE transition penalties.,
Please approve.

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@sviswa7
8320206: The approval request was already up to date.

@openjdk openjdk bot added the approval label Dec 19, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320206: Some intrinsics/stubs missing vzeroupper on x86_64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • aaee2d7: 8322040: Missing array bounds check in ClassReader.parameter
  • 636607b: 8313816: Accessing jmethodID might lead to spurious crashes
  • e4056b9: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
  • 12915c3: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
  • e0de68e: 8209595: MonitorVmStartTerminate.java timed out
  • 2f65dda: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • 840724b: 8317188: G1: Make TestG1ConcRefinementThreads use createTestJvm
  • a6c2398: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
  • a565d49: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • eb6fedc: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
  • ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/3e4adb6fd4c057d87cc0ddf448913ed49d8fc342...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 21, 2023
@sviswa7
Copy link
Author

sviswa7 commented Dec 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@sviswa7
Your change (at version 409f0e4) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 30, 2023

Going to push as commit 98fb425.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 3465179: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
  • 191fc6b: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 80c86c2: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • 8517987: 8312428: PKCS11 tests fail with NSS 3.91
  • 9e24862: 8313720: C2 SuperWord: wrong result with -XX:+UseVectorCmov -XX:+UseCMoveUnconditionally
  • 4c5502d: 8310919: runtime/ErrorHandling/TestAbortVmOnException.java times out due to core dumps taking a long time on OSX
  • 03b01a9: 8304292: Memory leak related to ClassLoader::update_class_path_entry_list
  • a607f49: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
  • 98c94fd: 8264899: C1: -XX:AbortVMOnException does not work if all methods in the call stack are compiled with C1 and there are no exception handlers
  • a17d0c4: 8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder
  • ... and 44 more: https://git.openjdk.org/jdk21u-dev/compare/3e4adb6fd4c057d87cc0ddf448913ed49d8fc342...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2023
@openjdk openjdk bot closed this Dec 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@TheRealMDoerr @sviswa7 Pushed as commit 98fb425.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sviswa7
Copy link
Author

sviswa7 commented Dec 30, 2023

Thanks a lot @TheRealMDoerr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants