Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless #752

Closed
wants to merge 2 commits into from

Conversation

amosshi
Copy link

@amosshi amosshi commented Jun 19, 2024

Backport of JDK-8315969

  • The change on file TestRangeCheckHoistingScaledIV.java is clean, because it is auto done by git patch command
  • The test/hotspot/jtreg/ProblemList.txt file in the original commit is ignored, because the line does not exist
  • So this PR can be considered as clean

Testing

  • Local: Test passed
    • TestRangeCheckHoistingScaledIV.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-06-23
    • jtreg_hotspot_tier2: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: SUCCESSFUL GitHub 📊⏲ - [4,593 msec]

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315969 needs maintainer approval

Issue

  • JDK-8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/752/head:pull/752
$ git checkout pull/752

Update a local copy of the PR:
$ git checkout pull/752
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 752

View PR using the GUI difftool:
$ git pr show -t 752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/752.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • 432144b: 8316211: Open source several manual applet tests
  • a045d78: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
  • c77926c: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
  • 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
  • d2534fa: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • 420c4b5: 8316389: Open source few AWT applet tests
  • 8094990: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 2ed8a96: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • edbe6f9: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • d927a6f: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
  • ... and 67 more: https://git.openjdk.org/jdk21u-dev/compare/e716aaec1295e0d378924c08d6f698ac92b2dc4e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9598ff83860235281a08091128b5df90a4a76916 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor

I think you need to update the problem list (see Error above).

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Author

amosshi commented Jun 24, 2024

/approval request "Backporting for parity with 21.0.5-oracle. No risk, test fix. Un-Clean backport. Test passes and SAP nightlies pass on 2024-06-23”

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@amosshi
8315969: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 24, 2024
@amosshi
Copy link
Author

amosshi commented Jun 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit 8c00900.
Since your change was applied there have been 100 commits pushed to the master branch:

  • d7db5c5: 8320608: Many jtreg printing tests are missing the @printer keyword
  • 9a4da24: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • 153accc: 8330849: Add test to verify memory usage with recursive locking
  • 99b50b3: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 8c6ad58: 8317372: Refactor some NumberFormat tests to use JUnit
  • 98cfde4: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • 2c3a40b: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • c0050ca: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
  • 4be1a02: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • 17e271d: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files.
  • ... and 90 more: https://git.openjdk.org/jdk21u-dev/compare/e716aaec1295e0d378924c08d6f698ac92b2dc4e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@amosshi Pushed as commit 8c00900.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8315969 branch August 8, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants