Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8051959: Add thread and timestamp options to java.security.debug system property #761

Closed
wants to merge 2 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 19, 2024

Backport of JDK-8051959. Hunks which belong to JDK-8327818 are omitted because that one is not in 21u. The rest applies cleanly. Included test has passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8327569 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8051959 needs maintainer approval

Issues

  • JDK-8051959: Add thread and timestamp options to java.security.debug system property (Enhancement - P4 - Approved)
  • JDK-8327569: Add thread and timestamp options to java.security.debug system property (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/761/head:pull/761
$ git checkout pull/761

Update a local copy of the PR:
$ git checkout pull/761
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/761/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 761

View PR using the GUI difftool:
$ git pr show -t 761

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/761.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8051959: Add thread and timestamp options to java.security.debug system property

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 8c00900: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • d7db5c5: 8320608: Many jtreg printing tests are missing the @printer keyword
  • 9a4da24: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • 153accc: 8330849: Add test to verify memory usage with recursive locking
  • 99b50b3: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 8c6ad58: 8317372: Refactor some NumberFormat tests to use JUnit
  • 98cfde4: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • 2c3a40b: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • c0050ca: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
  • 4be1a02: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • ... and 44 more: https://git.openjdk.org/jdk21u-dev/compare/f2e567ab13b0dac0bd4bd127ee10dac3e9f4240b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3b582dff849f1c25336e2efc415eb121f8b12189 8051959: Add thread and timestamp options to java.security.debug system property Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 19, 2024
@openjdk
Copy link

openjdk bot commented Jun 19, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2024

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 21.0.5-oracle. The backport has been reviewed and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@TheRealMDoerr
8051959: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 25, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

Going to push as commit e257ae5.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 4dceb87: 8321176: [Screencast] make a second attempt on screencast failure
  • 8c00900: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • d7db5c5: 8320608: Many jtreg printing tests are missing the @printer keyword
  • 9a4da24: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • 153accc: 8330849: Add test to verify memory usage with recursive locking
  • 99b50b3: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 8c6ad58: 8317372: Refactor some NumberFormat tests to use JUnit
  • 98cfde4: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • 2c3a40b: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • c0050ca: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
  • ... and 45 more: https://git.openjdk.org/jdk21u-dev/compare/f2e567ab13b0dac0bd4bd127ee10dac3e9f4240b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2024
@openjdk openjdk bot closed this Jun 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@TheRealMDoerr Pushed as commit e257ae5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8051959_timestamp branch June 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants