-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319197: Exclude hb-subset and hb-style from compilation #769
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to improve JDK build times. Was in mainline for months without ill effects. If we stop compiling something that JDK needed, it should have likely ended in linkage error during the build. Risk is therefore low. |
/integrate |
Going to push as commit 11628ef.
Your commit was automatically rebased without conflicts. |
Clean backport to improve JDK build times.
Yields a very reproducible improvement:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/769/head:pull/769
$ git checkout pull/769
Update a local copy of the PR:
$ git checkout pull/769
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/769/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 769
View PR using the GUI difftool:
$ git pr show -t 769
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/769.diff
Webrev
Link to Webrev Comment