Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319197: Exclude hb-subset and hb-style from compilation #769

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 20, 2024

Clean backport to improve JDK build times.

Yields a very reproducible improvement:

CONF=linux-x86_64-server-fastdebug make clean images   2484.89s user 417.72s system 2357% cpu 2:03.10 total
CONF=linux-x86_64-server-fastdebug make clean images   2481.81s user 417.23s system 2368% cpu 2:02.43 total
CONF=linux-x86_64-server-fastdebug make clean images   2487.89s user 417.50s system 2374% cpu 2:02.36 total

After:
CONF=linux-x86_64-server-fastdebug make clean images   2435.98s user 410.01s system 2538% cpu 1:52.10 total
CONF=linux-x86_64-server-fastdebug make clean images   2433.32s user 412.24s system 2546% cpu 1:51.75 total
CONF=linux-x86_64-server-fastdebug make clean images   2446.09s user 414.37s system 2535% cpu 1:52.81 total

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319197 needs maintainer approval

Issue

  • JDK-8319197: Exclude hb-subset and hb-style from compilation (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/769/head:pull/769
$ git checkout pull/769

Update a local copy of the PR:
$ git checkout pull/769
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 769

View PR using the GUI difftool:
$ git pr show -t 769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/769.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319197: Exclude hb-subset and hb-style from compilation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • fe999ba: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"
  • d5363bc: 8332174: Remove 2 (unpaired) RLO Unicode characters in ff_Adlm.xml
  • c3693c2: 8327840: Automate javax/swing/border/Test4129681.java
  • 6a67861: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e1cae7203674bc288a63e6fb26f94b20e70c74fd 8319197: Exclude hb-subset and hb-style from compilation Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve JDK build times. Was in mainline for months without ill effects. If we stop compiling something that JDK needed, it should have likely ended in linkage error during the build. Risk is therefore low.

@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@shipilev
8319197: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 20, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

Going to push as commit 11628ef.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 3222647: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
  • b0607ee: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 717e389: 8316306: Open source and convert manual Swing test
  • 241b054: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
  • 57824ed: 8321220: JFR: RecordedClass reports incorrect modifiers
  • 1c19bbd: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
  • 432144b: 8316211: Open source several manual applet tests
  • a045d78: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
  • c77926c: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
  • 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/a79db00d3017201d77baf7fdc3bbba1e34ccd50a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2024
@openjdk openjdk bot closed this Jun 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@shipilev Pushed as commit 11628ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant