Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #775

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jun 21, 2024

I backport this for parity with 21.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299487 needs maintainer approval

Issue

  • JDK-8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/775/head:pull/775
$ git checkout pull/775

Update a local copy of the PR:
$ git checkout pull/775
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 775

View PR using the GUI difftool:
$ git pr show -t 775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/775.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 432144b: 8316211: Open source several manual applet tests
  • a045d78: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
  • c77926c: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
  • 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
  • d2534fa: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • 420c4b5: 8316389: Open source few AWT applet tests
  • 8094990: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 2ed8a96: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • edbe6f9: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • d927a6f: 8325384: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java failing intermittently when main thread is a virtual thread
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/fe999ba7840f9bd306f46178747e743a502d3535...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 81083a0e10d9c92f5247ae256e170709014b596b 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 24, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

Going to push as commit b0607ee.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 717e389: 8316306: Open source and convert manual Swing test
  • 241b054: 8325754: Dead AbstractQueuedSynchronizer$ConditionNodes survive minor garbage collections
  • 57824ed: 8321220: JFR: RecordedClass reports incorrect modifiers
  • 1c19bbd: 8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines
  • 432144b: 8316211: Open source several manual applet tests
  • a045d78: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"
  • c77926c: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
  • 62c30e6: 8333398: Uncomment the commented test in test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java
  • d2534fa: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • 420c4b5: 8316389: Open source few AWT applet tests
  • ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/fe999ba7840f9bd306f46178747e743a502d3535...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2024
@openjdk openjdk bot closed this Jun 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@luchenlin Pushed as commit b0607ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant