Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334441: Mark tests in jdk_security_infra group as manual #781

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 24, 2024

Hi all,

This pull request contains a backport of commit 8e1d2b09 from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was reviewed by Christoph Langer and Sean Mullan.

The file test/jdk/TEST.groups has a prefixed PR JDK-8257516 cause this backport not clean, and jdk21u-dev repo doesn't have file test/jdk/security/infra/javax/net/ssl/HttpsURLConnectionTest.java, other files are backported cleanly.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334441 needs maintainer approval

Issue

  • JDK-8334441: Mark tests in jdk_security_infra group as manual (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/781/head:pull/781
$ git checkout pull/781

Update a local copy of the PR:
$ git checkout pull/781
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 781

View PR using the GUI difftool:
$ git pr show -t 781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/781.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8e1d2b091c9a311d98a0b886a803fb18d4405d8a 8334441: Mark tests in jdk_security_infra group as manual Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2024

Webrevs

@RealCLanger
Copy link
Contributor

RealCLanger commented Jun 24, 2024

@sendaoYan Thanks for proposing the backports to jdk21, 17 and 11 updates. I suggest to take this test fix into the rampdown repositories, still. So, can you please open PRs against jdk21u, jdk17u and jdk11u and request approval (through *-critical requests if you do it via JBS). Thanks!

@sendaoYan
Copy link
Member Author

@sendaoYan Thanks for proposing the backports to jdk21, 17 and 11 updates. I suggest to take this test fix into the rampdown repositories, still. So, can you please open PRs against jdk21u, jdk17u and jdk11u and request approval (through *-critical requests if you do it via JBS). Thanks!

Okey.

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@sendaoYan
8334441: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jun 24, 2024
@TheRealMDoerr
Copy link
Contributor

Please close. It's in jdk21u.

@sendaoYan
Copy link
Member Author

Please close. It's in jdk21u.

Okey.

@sendaoYan sendaoYan closed this Jun 25, 2024
@sendaoYan sendaoYan deleted the jbs8334441 branch June 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants