-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334441: Mark tests in jdk_security_infra group as manual #781
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@sendaoYan Thanks for proposing the backports to jdk21, 17 and 11 updates. I suggest to take this test fix into the rampdown repositories, still. So, can you please open PRs against jdk21u, jdk17u and jdk11u and request approval (through *-critical requests if you do it via JBS). Thanks! |
Okey. |
/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk. |
@sendaoYan |
Please close. It's in jdk21u. |
Okey. |
Hi all,
This pull request contains a backport of commit 8e1d2b09 from the openjdk/jdk repository.
The commit being backported was authored by Rajan Halade on 21 Jun 2024 and was reviewed by Christoph Langer and Sean Mullan.
The file
test/jdk/TEST.groups
has a prefixed PRJDK-8257516
cause this backport not clean, andjdk21u-dev
repo doesn't have filetest/jdk/security/infra/javax/net/ssl/HttpsURLConnectionTest.java
, other files are backported cleanly.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/781/head:pull/781
$ git checkout pull/781
Update a local copy of the PR:
$ git checkout pull/781
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/781/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 781
View PR using the GUI difftool:
$ git pr show -t 781
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/781.diff
Webrev
Link to Webrev Comment