Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321176: [Screencast] make a second attempt on screencast failure #786

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 24, 2024

Clean backport of JDK-8321176.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321176 needs maintainer approval

Issue

  • JDK-8321176: [Screencast] make a second attempt on screencast failure (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/786/head:pull/786
$ git checkout pull/786

Update a local copy of the PR:
$ git checkout pull/786
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 786

View PR using the GUI difftool:
$ git pr show -t 786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/786.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321176: [Screencast] make a second attempt on screencast failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 8c00900: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • d7db5c5: 8320608: Many jtreg printing tests are missing the @printer keyword
  • 9a4da24: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • 153accc: 8330849: Add test to verify memory usage with recursive locking
  • 99b50b3: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 8c6ad58: 8317372: Refactor some NumberFormat tests to use JUnit
  • 98cfde4: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • 2c3a40b: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • c0050ca: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
  • 4be1a02: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/487b29d7954066bd09d0f0a6649864d8809d10fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 92fd490f22f690ff7698182658363b7035bcc3bf 8321176: [Screencast] make a second attempt on screencast failure Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Should get backported for parity with 21.0.5-oracle. Applies cleanly and tier 1-4 have passed.

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@TheRealMDoerr
8321176: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 25, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

Going to push as commit 4dceb87.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 8c00900: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • d7db5c5: 8320608: Many jtreg printing tests are missing the @printer keyword
  • 9a4da24: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • 153accc: 8330849: Add test to verify memory usage with recursive locking
  • 99b50b3: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 8c6ad58: 8317372: Refactor some NumberFormat tests to use JUnit
  • 98cfde4: 8222884: ConcurrentClassDescLookup.java times out intermittently
  • 2c3a40b: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • c0050ca: 8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length
  • 4be1a02: 8328697: SubMenuShowTest and SwallowKeyEvents tests stabilization
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/487b29d7954066bd09d0f0a6649864d8809d10fa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2024
@openjdk openjdk bot closed this Jun 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@TheRealMDoerr Pushed as commit 4dceb87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant