Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313882: Fix -Wconversion warnings in runtime code #788

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 24, 2024

Unclean backport to provide cleaner ground for future backports.

There were two minor conflicts in attachListener.cpp and globals.hpp.

Additional testing:

  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313882 needs maintainer approval

Issue

  • JDK-8313882: Fix -Wconversion warnings in runtime code (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/788/head:pull/788
$ git checkout pull/788

Update a local copy of the PR:
$ git checkout pull/788
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/788/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 788

View PR using the GUI difftool:
$ git pr show -t 788

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/788.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f47767ffef29c777e2da0262fa3299564d59f461 8313882: Fix -Wconversion warnings in runtime code Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 24, 2024
@shipilev shipilev force-pushed the JDK-8313882-fix-wconversion-runtime branch from 8385cfa to 9902de1 Compare June 24, 2024 10:55
@shipilev shipilev marked this pull request as ready for review July 11, 2024 11:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 11, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

On hold, I see that it breaks Graal due to field type change: JDK-8314247. The underlying reason for this backport is to make JDK-8327743 cleaner, but it might be too much of the risk to take for extra cleanliness.

@shipilev
Copy link
Member Author

Closing due to the reason above. JDK-8327743 backport (#523) had been amended to deviate a bit from upstream change. This will not break Graal just for backport cleanliness reasons.

@shipilev shipilev closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants