-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313882: Fix -Wconversion warnings in runtime code #788
8313882: Fix -Wconversion warnings in runtime code #788
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
8385cfa
to
9902de1
Compare
|
On hold, I see that it breaks Graal due to field type change: JDK-8314247. The underlying reason for this backport is to make JDK-8327743 cleaner, but it might be too much of the risk to take for extra cleanliness. |
Closing due to the reason above. JDK-8327743 backport (#523) had been amended to deviate a bit from upstream change. This will not break Graal just for backport cleanliness reasons. |
Unclean backport to provide cleaner ground for future backports.
There were two minor conflicts in
attachListener.cpp
andglobals.hpp
.Additional testing:
all
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/788/head:pull/788
$ git checkout pull/788
Update a local copy of the PR:
$ git checkout pull/788
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/788/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 788
View PR using the GUI difftool:
$ git pr show -t 788
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/788.diff
Webrev
Link to Webrev Comment