Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform #79

Closed

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Dec 21, 2023

Hi, The same issue also exists in the JDK21U: I can reproduce it locally by applying fix for JDK-8320886 and running test/hotspot/jtreg/runtime/Unsafe/InternalErrorTest.java test. So I would like to backport this to JDK21U. Tier1-3 tested with fastdebug build using qemu systems. This is a risc-v specific change. Backport is clean, risk is low.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321972 needs maintainer approval

Issue

  • JDK-8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/79.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8768ae08dbee9c3e1ed01934142c03ffad5f349 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • aaee2d7: 8322040: Missing array bounds check in ClassReader.parameter
  • 636607b: 8313816: Accessing jmethodID might lead to spurious crashes
  • e4056b9: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
  • 12915c3: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
  • e0de68e: 8209595: MonitorVmStartTerminate.java timed out
  • 2f65dda: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • 840724b: 8317188: G1: Make TestG1ConcRefinementThreads use createTestJvm
  • a6c2398: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
  • a565d49: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • eb6fedc: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/9aad573ac8224109d0bac125cc61c6a525fb126a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 21, 2023
@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@zifeihan
Your change (at version dafa3cd) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 22, 2023

Going to push as commit 7927315.
Since your change was applied there have been 23 commits pushed to the master branch:

  • aaee2d7: 8322040: Missing array bounds check in ClassReader.parameter
  • 636607b: 8313816: Accessing jmethodID might lead to spurious crashes
  • e4056b9: 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
  • 12915c3: 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from
  • e0de68e: 8209595: MonitorVmStartTerminate.java timed out
  • 2f65dda: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • 840724b: 8317188: G1: Make TestG1ConcRefinementThreads use createTestJvm
  • a6c2398: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
  • a565d49: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • eb6fedc: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/9aad573ac8224109d0bac125cc61c6a525fb126a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2023
@openjdk openjdk bot closed this Dec 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@RealFYang @zifeihan Pushed as commit 7927315.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants