Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jun 26, 2024

Hi all,

This pull request contains a backport of commit 999e556b from the openjdk/jdk repository.

The commit being backported was authored by Harshitha Onkar on 12 Jan 2024 and was reviewed by Sergey Bylokhov, Tejesh R and Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312518 needs maintainer approval

Issue

  • JDK-8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/793/head:pull/793
$ git checkout pull/793

Update a local copy of the PR:
$ git checkout pull/793
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 793

View PR using the GUI difftool:
$ git pr show -t 793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/793.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 347ef64: Merge
  • c4d39f3: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 0b340d1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 999e556be4302de4b6911e6d62ee5ca556a76469 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 26, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb mrserb marked this pull request as ready for review September 12, 2024 03:01
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 12, 2024
@mrserb
Copy link
Member Author

mrserb commented Sep 12, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

Going to push as commit 29b65ab.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f280507: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
  • 347ef64: Merge
  • c4d39f3: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • 0b340d1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2024
@openjdk openjdk bot closed this Sep 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@mrserb Pushed as commit 29b65ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant