8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)

[shipilev]

This batch of fixes improves the warnings handling for newer GCCs. These issues are a bit interdependent contextually, so I opted to pick them up in one batch, making it abundantly clear what are we adding.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8319818 needs maintainer approval
• JDK-8320212 needs maintainer approval
• JDK-8326717 needs maintainer approval

Issues

• JDK-8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) (Enhancement - P4 - Approved)
• JDK-8320212: Disable GCC stringop-overflow warning for affected files (Bug - P4 - Approved)
• JDK-8326717: Disable stringop-overflow in shenandoahLock.cpp (Bug - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/797/head:pull/797
$ git checkout pull/797

Update a local copy of the PR:
$ git checkout pull/797
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/797/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 797

View PR using the GUI difftool:
$ git pr show -t 797

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/797.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[shipilev]

/issue add JDK-8320212
/issue add JDK-8326717

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)
8320212: Disable GCC stringop-overflow warning for affected files
8326717: Disable stringop-overflow in shenandoahLock.cpp

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• b15ec4a: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
• 6b4fa86: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
• e456f8b: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• 75287b5: 8330027: Identity hashes of archived objects must be based on a reproducible random seed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev
Adding additional issue to issue list: 8320212: Disable GCC stringop-overflow warning for affected files.

[openjdk]

@shipilev
Adding additional issue to issue list: 8326717: Disable stringop-overflow in shenandoahLock.cpp.

[mlbridge]

Webrevs

• 00: Full (ce349e68)

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

Thanks!

[shipilev]

/approval request This batch of fixes improves the warnings handling for newer GCCs. Part of atomic 21u PR, since it contextually depends on other fixes. Risk is low: adds warnings and moves the code around. Was in mainline for months without ill effects.

[openjdk]

@shipilev
8319818: The approval request has been created successfully.
8320212: The approval request has been created successfully.
8326717: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit 6c65326.
Since your change was applied there have been 5 commits pushed to the master branch:

• 7ff9ec6: 8333462: Performance regression of new DecimalFormat() when compare to jdk11
• b15ec4a: 8211847: [aix] java/lang/ProcessHandle/InfoTest.java fails: "reported cputime less than expected"
• 6b4fa86: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
• e456f8b: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• 75287b5: 8330027: Identity hashes of archived objects must be based on a reproducible random seed

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 6c65326.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.