Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319650: Improve heap dump performance with class metadata caching #8

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 13, 2023

Transplanted from openjdk/jdk21u#388

Unclean backport to improve heap dump performance. The uncleanliness comes from JDK-8306441 that does not exist in JDK 21, and which I don't think we want to backport at the moment. I had to add a few more ResourceMark-s near HeapDumpWriter to manage the cache allocations.

Additional testing:

  • MacOS AArch64 server release, heap dump performance improved
  • Linux x86_64 server fastdebug, serviceability/ (contains heap dump tests)
  • Linux x86_64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests)
  • Linux x86_64 server fastdebug, gc/epsilon (contains heap dump on failure tests)
  • Linux x86_64 server fastdebug, sun/tools/jhsdb (contains heap dump tests)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8319650 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8319650: Improve heap dump performance with class metadata caching (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/8.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03db82818b905f21cb5ad1d56a687e238b4a6e33 8319650: Improve heap dump performance with class metadata caching Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

shipilev commented Feb 3, 2024

Not now, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2024

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the approval label Mar 7, 2024
@shipilev
Copy link
Member Author

shipilev commented Mar 7, 2024

/approval request Unclean backport to improve heap dump performance. Tests pass. Original 21u RFR acked by Paul Hohensee. In mainline since Nov 2023 without a bug tail. The risk is in regressing the frequently used diagnostic subsystem, but that should be considered against the major improvement in performance.

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@shipilev
8319650: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319650: Improve heap dump performance with class metadata caching

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 5, 2024
@shipilev
Copy link
Member Author

shipilev commented Apr 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

Going to push as commit d5f44dc.
Since your change was applied there have been 13 commits pushed to the master branch:

  • b9ca253: 8325203: System.exit(0) kills the launched 3rd party application
  • 1c4479f: 8325567: jspawnhelper without args fails with segfault
  • 35f291b: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
  • 2a56bfb: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
  • d5c170a: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
  • e5ee283: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • 3b3ec13: 8314975: JavadocTester should set source path if not specified
  • e5c1031: 8293069: Make -XX:+Verbose less verbose
  • 8ed46c2: 8294699: Launcher causes lingering busy cursor
  • e1f8f83: 8316460: 4 javax/management tests ignore VM flags
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 9, 2024
@openjdk openjdk bot closed this Apr 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@shipilev Pushed as commit d5f44dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8319650-heapdump-cache-class branch April 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants