Skip to content

8334653: ISO 4217 Amendment 177 Update #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 28, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334653 needs maintainer approval

Issue

  • JDK-8334653: ISO 4217 Amendment 177 Update (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/804/head:pull/804
$ git checkout pull/804

Update a local copy of the PR:
$ git checkout pull/804
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 804

View PR using the GUI difftool:
$ git pr show -t 804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/804.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334653: ISO 4217 Amendment 177 Update

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • c8fe1a1: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • 4f82229: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
  • cba69c8: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
  • 34175fc: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
  • 306aeab: 8280988: [XWayland] Click on title to request focus test failures
  • b6be31a: 8320675: PrinterJob/SecurityDialogTest.java hangs
  • efcac3a: 8328238: Convert few closed manual applet tests to main
  • ded1a33: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • c22cb4a: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
  • 3b9abf9: 8330063: Upgrade jQuery to 3.7.1
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/15462799dad3282a27e5881c53f16942d7c1fe2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 86b0cf259fb3cbe3a1973151148e5d36c6a99d91 8334653: ISO 4217 Amendment 177 Update Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@openjdk openjdk bot added the approval label Jul 1, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Jul 4, 2024

@MBaesken Please also backport this to 23u: https://github.com/openjdk/jdk23u

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 4, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 5, 2024

@MBaesken Please also backport this to 23u: https://github.com/openjdk/jdk23u

There is already a PR open, see https://bugs.openjdk.org/browse/JDK-8334653
A pull request was submitted for review.
URL: https://git.openjdk.org/jdk23u/pull/13

@MBaesken
Copy link
Member Author

MBaesken commented Jul 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

Going to push as commit 7991298.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 7027274: 8333353: Delete extra empty line in CodeBlob.java
  • c8fe1a1: 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64
  • 4f82229: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
  • cba69c8: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
  • 34175fc: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
  • 306aeab: 8280988: [XWayland] Click on title to request focus test failures
  • b6be31a: 8320675: PrinterJob/SecurityDialogTest.java hangs
  • efcac3a: 8328238: Convert few closed manual applet tests to main
  • ded1a33: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • c22cb4a: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/15462799dad3282a27e5881c53f16942d7c1fe2b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2024
@openjdk openjdk bot closed this Jul 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@MBaesken Pushed as commit 7991298.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants