Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 #805

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 28, 2024

Hi all,

This pull request contains a backport of commit f23295ec from the openjdk/jdk repository.

The commit being backported was authored by Daniel Fuchs on 26 Jun 2024 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334600 needs maintainer approval

Issue

  • JDK-8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/805/head:pull/805
$ git checkout pull/805

Update a local copy of the PR:
$ git checkout pull/805
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 805

View PR using the GUI difftool:
$ git pr show -t 805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/805.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ded1a33: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • c22cb4a: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
  • 3b9abf9: 8330063: Upgrade jQuery to 3.7.1
  • f5e7166: 8316285: Opensource JButton manual tests
  • 813ca6d: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
  • eff4452: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
  • bcdb838: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f23295ec1dde58d239a2625c9b1645534a2bb625 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8334600 to fix the testcase bug, only change the testcase, no risk.

@openjdk
Copy link

openjdk bot commented Jun 29, 2024

@sendaoYan
8334600: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 29, 2024
@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8334600 to fix the testcase bug, make the more robustness. Only change test testcase, no risk.

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

@sendaoYan
8334600: The approval request has been updated successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 2, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 3, 2024
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@sendaoYan
Your change (at version d73a9f7) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Jul 4, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

Going to push as commit c8fe1a1.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 4f82229: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser
  • cba69c8: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
  • 34175fc: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
  • 306aeab: 8280988: [XWayland] Click on title to request focus test failures
  • b6be31a: 8320675: PrinterJob/SecurityDialogTest.java hangs
  • efcac3a: 8328238: Convert few closed manual applet tests to main
  • ded1a33: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • c22cb4a: 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV
  • 3b9abf9: 8330063: Upgrade jQuery to 3.7.1
  • f5e7166: 8316285: Opensource JButton manual tests
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/15462799dad3282a27e5881c53f16942d7c1fe2b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2024
@openjdk openjdk bot closed this Jul 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@jerboaa @sendaoYan Pushed as commit c8fe1a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants