Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320675: PrinterJob/SecurityDialogTest.java hangs #813

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jul 2, 2024

I backport this for parity with 21.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320675 needs maintainer approval

Issue

  • JDK-8320675: PrinterJob/SecurityDialogTest.java hangs (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/813/head:pull/813
$ git checkout pull/813

Update a local copy of the PR:
$ git checkout pull/813
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 813

View PR using the GUI difftool:
$ git pr show -t 813

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/813.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320675: PrinterJob/SecurityDialogTest.java hangs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9f5ad43358a4e209b4cd1c91bcc86b997f371548 8320675: PrinterJob/SecurityDialogTest.java hangs Jul 2, 2024
@openjdk
Copy link

openjdk bot commented Jul 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 2, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 3, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

Going to push as commit b6be31a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • efcac3a: 8328238: Convert few closed manual applet tests to main

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2024
@openjdk openjdk bot closed this Jul 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@luchenlin Pushed as commit b6be31a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant