8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly

[limingliu-ampere]

This pull request ports JDK-8315923 back to JDK-21, as JDK-21 still uses atomic-add-0 to pretouch memory and results fragmented huge pages. This backport has the following differences from its original version:

• TestTransparentHugePageUsage.java gets deleted as it was deleted in JDK-8324776;
• nullptr is adopted in pretouch_thp_and_use_concurrent, as it is a part of JDK-8327171;
• JDK-8324781 is included, as JDK-8324781 only makes changes to testcases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324781 needs maintainer approval
• JDK-8315923 needs maintainer approval
• JDK-8325218 needs maintainer approval

Issues

• JDK-8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly (Bug - P4 - Approved)
• JDK-8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved (Bug - P2 - Approved)
• JDK-8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails (Bug - P3 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/825/head:pull/825
$ git checkout pull/825

Update a local copy of the PR:
$ git checkout pull/825
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/825/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 825

View PR using the GUI difftool:
$ git pr show -t 825

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/825.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@limingliu-ampere This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315923: pretouch_memory by atomic-add-0 fragments huge pages unexpectedly
8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• bbcce3f: 8331518: Tests should not use the "Classpath" exception form of the legal header
• 5f78ddd: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
• dc3d552: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
• 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/79912989fe30b4adf1d7b7ffe3d7f3e01b7052c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (4b4446e8)

[shipilev]

I have questions:

1. If JDK-8324781 is included, you need to say /issue add JDK-8324781, and later request approval for it as well.
2. Looking at issue links, what about JDK-8325218?

[limingliu-ampere]

/issue add JDK-8324781 JDK-8325218

[openjdk]

@limingliu-ampere
Adding additional issue to issue list: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved.

Adding additional issue to issue list: 8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails.

[limingliu-ampere]

Hi @shipilev! Thank you for your suggestions. The root case of JDK-8324781 and JDK-8325218 are the same, so they were solved in the same commit. I added them altogether.

[shipilev]

All right, this makes sense, thanks!

[openjdk]

⚠️ @limingliu-ampere This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[limingliu-ampere]

/approval 8315923 request

[openjdk]

@limingliu-ampere
8315923: The approval request has been created successfully.

[limingliu-ampere]

/approval 8324781 request

[limingliu-ampere]

/approval 8325218 request

[openjdk]

@limingliu-ampere
8324781: The approval request has been created successfully.

[openjdk]

@limingliu-ampere
8325218: The approval request has been created successfully.

[limingliu-ampere]

/integrate

[openjdk]

@limingliu-ampere
Your change (at version 4b4446e) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit cb40bc2.
Since your change was applied there have been 11 commits pushed to the master branch:

• bbcce3f: 8331518: Tests should not use the "Classpath" exception form of the legal header
• 5f78ddd: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
• dc3d552: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
• 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
• 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out
• 6ff7e2a: 8334297: (so) java/nio/channels/SocketChannel/OpenLeak.java should not depend on SecurityManager
• 2c2cd9b: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• 3e638bf: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• b48b8e1: 8333804: java/net/httpclient/ForbiddenHeadTest.java threw an exception with 0 failures
• ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/79912989fe30b4adf1d7b7ffe3d7f3e01b7052c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @limingliu-ampere Pushed as commit cb40bc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.