Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp #829

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 8, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8317449 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317446 needs maintainer approval
  • JDK-8334592 needs maintainer approval

Issues

  • JDK-8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp (Sub-task - P4 - Approved)
  • JDK-8317449: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms (Sub-task - P4 - Approved)
  • JDK-8334592: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java in jdk21 on all platforms (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/829/head:pull/829
$ git checkout pull/829

Update a local copy of the PR:
$ git checkout pull/829
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 829

View PR using the GUI difftool:
$ git pr show -t 829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/829.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
8317449: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms
8334592: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java in jdk21 on all platforms

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
  • 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8ff10a0d3520fbeae9fe7aac4226d65b93ec79f8 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue https://bugs.openjdk.org/browse/JDK-8316392 was already fixed and the fix backported to JDK 21 Updates. So the respective line should be removed and the issue JDK-8317448 removed from this PR via the "/issue remove" command.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 8, 2024

/issue remove JDK-8317448

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@MBaesken
Removing additional issue from issue list: 8317448.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 8, 2024

Should i remove the whole line
compiler/interpreter/TestVerifyStackAfterDeopt.java 8316392 macosx-aarch64
from the PR ? But then it would not be clean any more.

@RealCLanger
Copy link
Contributor

Should i remove the whole line compiler/interpreter/TestVerifyStackAfterDeopt.java 8316392 macosx-aarch64 from the PR ? But then it would not be clean any more.

Yes, but that's no problem as long as it's properly reviewed in the end. We should do the right thing. 😄

@RealCLanger
Copy link
Contributor

Could you please also add JDK-8334592 to this PR for the bookkeeping? I understand that that's the actual issue that we want to do in JDK 21 updates for Oracle parity. Thanks.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 8, 2024

/issue add JDK-8334592

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@MBaesken
Adding additional issue to issue list: 8334592: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java in jdk21 on all platforms.

remove TestVerifyStackAfterDeopt.java fixed here https://bugs.openjdk.org/browse/JDK-8316392
@openjdk openjdk bot removed the clean label Jul 8, 2024
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBaesken
Copy link
Member Author

MBaesken commented Jul 9, 2024

Thanks for the review !

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 9, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

Going to push as commit dc3d552.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8a0dd93: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 9677a85: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
  • 9c9a812: 8211854: [aix] java/net/ServerSocket/AcceptInheritHandle.java fails: read times out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2024
@openjdk openjdk bot closed this Jul 9, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 9, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@MBaesken Pushed as commit dc3d552.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants