-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp #829
8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp #829
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issues from the original commit. |
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue https://bugs.openjdk.org/browse/JDK-8316392 was already fixed and the fix backported to JDK 21 Updates. So the respective line should be removed and the issue JDK-8317448 removed from this PR via the "/issue remove" command.
/issue remove JDK-8317448 |
@MBaesken |
Should i remove the whole line |
Yes, but that's no problem as long as it's properly reviewed in the end. We should do the right thing. 😄 |
Could you please also add JDK-8334592 to this PR for the bookkeeping? I understand that that's the actual issue that we want to do in JDK 21 updates for Oracle parity. Thanks. |
/issue add JDK-8334592 |
@MBaesken |
remove TestVerifyStackAfterDeopt.java fixed here https://bugs.openjdk.org/browse/JDK-8316392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the review ! |
/integrate |
Going to push as commit dc3d552.
Your commit was automatically rebased without conflicts. |
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/829/head:pull/829
$ git checkout pull/829
Update a local copy of the PR:
$ git checkout pull/829
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/829/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 829
View PR using the GUI difftool:
$ git pr show -t 829
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/829.diff
Webrev
Link to Webrev Comment