-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer #836
Conversation
👋 Welcome back luwang1103! A progress list of the required criteria for merging this PR into |
@luwang1103 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
This one is clean, just apply for approval. |
/approval request The code applies cleanly. Low risk: It is a corner case which is not triggered by the current code. In order to avoid bugs in the future, it is good to backport it. |
@luwang1103 |
@luwang1103 please bring this to jdk23u first. Thanks. |
Okay~~ |
This question has been successfully submitted in jdk23u, what should I do next? Thanks. |
Reapply for approval. Since the original fix request comment is already there, I just re-added |
/approval request The code applies cleanly. Low risk: It is a corner case which is not triggered by the current code. In order to avoid bugs in the future, it is good to backport it. |
@luwang1103 |
|
/integrate |
@luwang1103 |
/sponsor |
Going to push as commit 9176fa2.
Your commit was automatically rebased without conflicts. |
@RealCLanger @luwang1103 Pushed as commit 9176fa2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi @shipilev ,
This pull request contains a backport of commit 6861766b from the master repository.
The commit being backported was authored by Matthias Baesken on 14 Jun 2024.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/836/head:pull/836
$ git checkout pull/836
Update a local copy of the PR:
$ git checkout pull/836
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/836/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 836
View PR using the GUI difftool:
$ git pr show -t 836
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/836.diff
Webrev
Link to Webrev Comment