Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer #836

Closed
wants to merge 1 commit into from

Conversation

luwang1103
Copy link
Contributor

@luwang1103 luwang1103 commented Jul 12, 2024

Hi @shipilev ,

This pull request contains a backport of commit 6861766b from the master repository.

The commit being backported was authored by Matthias Baesken on 14 Jun 2024.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332818 needs maintainer approval

Issue

  • JDK-8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/836/head:pull/836
$ git checkout pull/836

Update a local copy of the PR:
$ git checkout pull/836
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 836

View PR using the GUI difftool:
$ git pr show -t 836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/836.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2024

👋 Welcome back luwang1103! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@luwang1103 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6861766b638c5135ba40f261d78d9731954ce5ab 8332818: ubsan: archiveHeapLoader.cpp:70:27: runtime error: applying non-zero offset 18446744073707454464 to null pointer Jul 12, 2024
@openjdk
Copy link

openjdk bot commented Jul 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

⚠️ @luwang1103 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2024

Webrevs

@shipilev
Copy link
Member

This one is clean, just apply for approval.

@luwang1103
Copy link
Contributor Author

/approval request The code applies cleanly. Low risk: It is a corner case which is not triggered by the current code. In order to avoid bugs in the future, it is good to backport it.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@luwang1103
8332818: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 12, 2024
@RealCLanger
Copy link
Contributor

@luwang1103 please bring this to jdk23u first. Thanks.

@openjdk openjdk bot removed the approval label Jul 12, 2024
@luwang1103
Copy link
Contributor Author

@luwang1103 please bring this to jdk23u first. Thanks.

Okay~~

@luwang1103
Copy link
Contributor Author

@luwang1103 please bring this to jdk23u first. Thanks.

This question has been successfully submitted in jdk23u, what should I do next? Thanks.

@shipilev
Copy link
Member

shipilev commented Jul 18, 2024

This question has been successfully submitted in jdk23u, what should I do next? Thanks.

Reapply for approval. Since the original fix request comment is already there, I just re-added jdk21u-fix-request tag on the issue.

@openjdk openjdk bot added the approval label Jul 18, 2024
@luwang1103
Copy link
Contributor Author

/approval request The code applies cleanly. Low risk: It is a corner case which is not triggered by the current code. In order to avoid bugs in the future, it is good to backport it.

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@luwang1103
8332818: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

⚠️ @luwang1103 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout ubsan-second
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 18, 2024
@luwang1103
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 18, 2024
@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@luwang1103
Your change (at version 7ddd3bc) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

Going to push as commit 9176fa2.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 021e881: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
  • 7e5d30f: 8334123: log the opening of Type 1 fonts
  • 9a02aa6: 8333887: ubsan: unsafe.cpp:247:13: runtime error: store to null pointer of type 'volatile int'
  • be519cd: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
  • 4e95699: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • ed1106b: Merge
  • d6e8788: 8335960: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.4
  • dafbd18: 8320548: Improved loop handling
  • e69045f: 8327413: Enhance compilation efficiency
  • 23b8753: 8324559: Improve 2D image handling
  • ... and 11 more: https://git.openjdk.org/jdk21u-dev/compare/c8db6fe9536148aee152710bad72cd025393e477...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2024
@openjdk openjdk bot closed this Jul 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2024
@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@RealCLanger @luwang1103 Pushed as commit 9176fa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants