8319817: Charset constructor should make defensive copy of aliases

[toddjonker]

Clean backport.

Additional testing:

• New regression test fails without the fix, passes with it
• linux-x86_64-server-release: JTREG_KEYWORDS="\!headful & \!external-dep & \!printer" make test TEST=all
  • These tests fail repeatedly, but also fail on master:
    • build/AbsPathsInImage.java
    • java/nio/channels/FileChannel/directio/DirectIOTest.java

---

Progress

• JDK-8319817 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319817: Charset constructor should make defensive copy of aliases (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/841/head:pull/841
$ git checkout pull/841

Update a local copy of the PR:
$ git checkout pull/841
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/841/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 841

View PR using the GUI difftool:
$ git pr show -t 841

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/841.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @toddjonker, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user toddjonker" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@toddjonker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319817: Charset constructor should make defensive copy of aliases

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 108c2e4: 8334166: Enable binary check
• 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• 6196ed1: 8332113: Update nsk.share.Log to be always verbose
• 785ae1f: 8315965: Open source various AWT applet tests
• 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[toddjonker]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (92503f50)
• 00: Full (5a733371)

[toddjonker]

/approval request Clean backport of fix originally authored by @naotoj
Passes all headless tests modulo two known to be flaky in our environment; see PR for details.

[openjdk]

@toddjonker
8319817: The approval request has been created successfully.

[toddjonker]

/integrate

[openjdk]

@toddjonker
Your change (at version 92503f5) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit edd6437.
Since your change was applied there have been 7 commits pushed to the master branch:

• 590715f: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
• 108c2e4: 8334166: Enable binary check
• 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• 6196ed1: 8332113: Update nsk.share.Log to be always verbose
• 785ae1f: 8315965: Open source various AWT applet tests
• 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @toddjonker Pushed as commit edd6437.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.