Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 #856

Closed
wants to merge 2 commits into from

Conversation

toddjonker
Copy link
Contributor

@toddjonker toddjonker commented Jul 19, 2024

This is a clean backport of openjdk/jdk@64c3642 originally authored by @vpa1977 and reviewed by @jonathan-gibbons

Additional testing:

  • New regression test fails without the fix, passes with it
  • linux-x86_64-server-release: make test TEST=test/langtools/jdk/javadoc

Progress

  • JDK-8242564 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/856/head:pull/856
$ git checkout pull/856

Update a local copy of the PR:
$ git checkout pull/856
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 856

View PR using the GUI difftool:
$ git pr show -t 856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/856.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 19, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2024

Hi @toddjonker, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user toddjonker" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2024

@toddjonker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 64c3642c57719940855b220025b33758950b3980 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6 Jul 19, 2024
@openjdk
Copy link

openjdk bot commented Jul 19, 2024

This backport pull request has now been updated with issue from the original commit.

@toddjonker
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jul 19, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@toddjonker toddjonker marked this pull request as ready for review July 24, 2024 16:00
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

⚠️ @toddjonker This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

@toddjonker
Copy link
Contributor Author

/approval request This is a clean backport of openjdk/jdk@64c3642 preventing a javadoc crash; originally authored by @vpa1977 and reviewed by @jonathan-gibbons.
Passes all tests in langtools/jdk/javadoc

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@toddjonker
8242564: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 12, 2024
@toddjonker
Copy link
Contributor Author

/integrate auto

@openjdk openjdk bot added the auto label Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@toddjonker This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@openjdk[bot]
Your change (at version f4b7f31) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

Going to push as commit 8150179.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 13, 2024
@openjdk openjdk bot closed this Aug 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@phohensee @toddjonker Pushed as commit 8150179.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@toddjonker toddjonker deleted the jdoc-crash branch August 13, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants