8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

[mmyxym]

Clean backport of fixing soft-ref resetting in Parallel Full GC.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335493 needs maintainer approval

Issue

• JDK-8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/857/head:pull/857
$ git checkout pull/857

Update a local copy of the PR:
$ git checkout pull/857
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 857

View PR using the GUI difftool:
$ git pr show -t 857

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/857.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
• 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
• c2daaa6: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
• a757e62: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
• c3b424e: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 7239584: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
• 43cb913: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
• e478a23: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout
• 462065b: 8335904: Fix invalid comment in ShenandoahLock
• ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/527ade8e30628e8815160a510af919fe6811851a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mmyxym]

/approva request It's for fixing soft-ref resetting in Parallel Full GC. The risk is very low.

[mlbridge]

Webrevs

• 00: Full (3a089b59)

[openjdk]

@mmyxym Unknown command approva - for a list of valid commands use /help.

[mmyxym]

/approval request It's for fixing soft-ref resetting in Parallel Full GC. The risk is very low.

[openjdk]

@mmyxym
8335493: The approval request has been created successfully.

[RealCLanger]

@mmyxym please bring to jdk23u first. Thanks!

[mmyxym]

@mmyxym please bring to jdk23u first. Thanks!

@RealCLanger It's in 23u now.

[mmyxym]

/approval request It's for fixing soft-ref resetting in Parallel Full GC. The risk is very low.

[openjdk]

@mmyxym
8335493: The approval request was already up to date.

[mmyxym]

/integrate

[openjdk]

@mmyxym
Your change (at version 3a089b5) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit ee21571.
Since your change was applied there have been 31 commits pushed to the master branch:

• 30294f4: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
• 3511d72: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 81d1c97: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• ce67ab0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• 7c2666d: 8335967: "text-decoration: none" does not work with "A" HTML tags
• 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
• 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
• c2daaa6: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
• a757e62: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
• ... and 21 more: https://git.openjdk.org/jdk21u-dev/compare/527ade8e30628e8815160a510af919fe6811851a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @mmyxym Pushed as commit ee21571.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.