8321509: False positive in get_trampoline fast path causes crash

[lutkerd]

We have a customer experiencing this crash in 21.0.3 with the same stack as the duplicate issue (JDK-8334136).

Ran tier1-4 on Linux aarch64 as well as a jcstress -m quick.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8321509 needs maintainer approval

Issue

• JDK-8321509: False positive in get_trampoline fast path causes crash (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/864/head:pull/864
$ git checkout pull/864

Update a local copy of the PR:
$ git checkout pull/864
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 864

View PR using the GUI difftool:
$ git pr show -t 864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/864.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321509: False positive in get_trampoline fast path causes crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• b79e185: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer
• ee21571: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
• 30294f4: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
• 3511d72: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 81d1c97: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• ce67ab0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• 7c2666d: 8335967: "text-decoration: none" does not work with "A" HTML tags
• 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
• 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
• ... and 21 more: https://git.openjdk.org/jdk21u-dev/compare/2c981bc9f3de491dff5571855697477c04ad873d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a80bb359)

[lutkerd]

/approval request backporting to fix an issue 1 of our customers has seen. There is some risk as there is no regression tests specifically for this bug and the customer repro is infrequent enough it is hard to test outside of production. Ran tier1-4 as well as jcstress -m quick on aarch64.

[openjdk]

@lutkerd usage: /approval [<id>] (request|cancel) [<text>]

[lutkerd]

/approval request backporting to fix an issue 1 of our customers has seen. There is some risk as there is no regression tests specifically for this bug and the customer repro is infrequent enough it is hard to test outside of production. Ran tier1-4 as well as jcstress -m quick on aarch64.

[openjdk]

@lutkerd
8321509: The approval request has been created successfully.

[RealCLanger]

@lutkerd Can you please backport this to jdk23u first? Thanks!

[lutkerd]

/integrate

[openjdk]

@lutkerd
Your change (at version a80bb35) is now ready to be sponsored by a Committer.

[benty-amzn]

/sponsor

[openjdk]

Going to push as commit 4989165.
Since your change was applied there have been 31 commits pushed to the master branch:

• b79e185: 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer
• ee21571: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
• 30294f4: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
• 3511d72: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 81d1c97: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• ce67ab0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
• 7c2666d: 8335967: "text-decoration: none" does not work with "A" HTML tags
• 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
• 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
• 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
• ... and 21 more: https://git.openjdk.org/jdk21u-dev/compare/2c981bc9f3de491dff5571855697477c04ad873d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@benty-amzn @lutkerd Pushed as commit 4989165.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.