8326332: Unclosed inline tags cause misalignment in summary tables

[MBaesken]

Backport of 8326332

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326332 needs maintainer approval

Issue

• JDK-8326332: Unclosed inline tags cause misalignment in summary tables (Bug - P3 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/866/head:pull/866
$ git checkout pull/866

Update a local copy of the PR:
$ git checkout pull/866
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 866

View PR using the GUI difftool:
$ git pr show -t 866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/866.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326332: Unclosed inline tags cause misalignment in summary tables

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• bba56e0: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4cab9a4: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error
• 928219d: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 03: Full - Incremental (d3cd0d5d)
• 02: Full - Incremental (c4ec708a)
• 01: Full - Incremental (83be6252)
• 00: Full (160c8baf)

[MBaesken]

replace jdk21 List getLast() / removeLast() methods , to be able to build with a Boot JDK 20; use the default method implementation of List, this should be okay here.

[RealCLanger]

I think you can remove the .isEmpty() check because in all places this is checked before calling getLast()/removeLast(). Maybe you want to just inline the code for a populated list in place?

[MBaesken]

I removed the isEmpty() check . But probably the performance gain is not very big (otherwise the jdk head coding should be revised).

[schmelter-sap]

Looks good so far.

[MBaesken]

I made the helpers as suggested 'private static' .

[schmelter-sap]

Looks good now.

[MBaesken]

/integrate

[openjdk]

Going to push as commit cc85abc.
Since your change was applied there have been 5 commits pushed to the master branch:

• bba56e0: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4cab9a4: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error
• 928219d: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit cc85abc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.