8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator

[shipilev]

Clean backport to sync up code bases and make the future backports clean. The change should have no material effect, since it just moves code around.

Additional testing:

• Linux AArch64 server fastdebug, hotspot_gc_shenandoah
• Linux AArch64 server fastdebug, tier1 with -XX:+UseShenandoahGC

---

Progress

• JDK-8334769 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/868/head:pull/868
$ git checkout pull/868

Update a local copy of the PR:
$ git checkout pull/868
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 868

View PR using the GUI difftool:
$ git pr show -t 868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/868.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error
• 928219d: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (363a5172)

[shipilev]

/approval request Clean backport to sync up code bases and make the future backports clean. Risk is low: the change just moves code around. Testing passes.

[openjdk]

@shipilev
8334769: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit 4cab9a4.
Since your change was applied there have been 3 commits pushed to the master branch:

• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error
• 928219d: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 4cab9a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.