8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native

[sendaoYan]

Hi all,
Test test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java invoke CreationTimeHelper in CreationTime.java, and CreationTimeHelper invoke native function. So test test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java should set as /native.
In the PR of backport JDK-8316304 to jdk21u-dev, this test has been rewritten to use JNI instead so as to avoid using Linker API, thus this is specific to jdk21u-dev and jdk17u-dev.
Trivial fix, the change has been verified, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8337038 needs maintainer approval

Issue

• JDK-8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/869/head:pull/869
$ git checkout pull/869

Update a local copy of the PR:
$ git checkout pull/869
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 869

View PR using the GUI difftool:
$ git pr show -t 869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/869.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 812a639: 8335283: Build failure due to 'no_sanitize' attribute directive ignored
• 4a267bd: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• 078524e: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
• cc85abc: 8326332: Unclosed inline tags cause misalignment in summary tables
• bba56e0: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4cab9a4: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (2c560095)

[sendaoYan]

/approval request Set java/nio/file/attribute/BasicFileAttributeView/CreationTime.java as /native, trivial fix, no risk.

[openjdk]

@sendaoYan
8337038: The approval request has been created successfully.

[RealCLanger]

@sendaoYan I can not see why this is specific to jdk21 and would call for a deviation from head. So, if you think this change is necessary, please close this PR and open another one in head to get it discussed and integrated. Should it be accepted you can try again with a backport.

[sendaoYan]

@sendaoYan I can not see why this is specific to jdk21 and would call for a deviation from head. So, if you think this change is necessary, please close this PR and open another one in head to get it discussed and integrated. Should it be accepted you can try again with a backport.

@RealCLanger In the PR of backport JDK-8316304 to jdk21u-dev, the description of PR says since the JDK 22 uses JEP 454 features in the test. I've rewritten the test to use JNI instead so as to avoid using @enablePreview in the test. So in the jdk mainline, this test do not use JNI.
Thus this is specific to jdk21u-dev and jdk17u-dev.

[RealCLanger]

OK, I understand. So please re-request approval once you've got a review of the PR.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sendaoYan]

Thanks all for the review.
/approval request Set java/nio/file/attribute/BasicFileAttributeView/CreationTime.java as /native, trivial fix, no risk.

[openjdk]

@sendaoYan
8337038: The approval request has been updated successfully.

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version 2c56009) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 2c9f741.
Since your change was applied there have been 8 commits pushed to the master branch:

• 812a639: 8335283: Build failure due to 'no_sanitize' attribute directive ignored
• 4a267bd: 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'
• 078524e: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
• cc85abc: 8326332: Unclosed inline tags cause misalignment in summary tables
• bba56e0: 8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
• 4cab9a4: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
• 570a6bd: 8310628: GcInfoBuilder.c missing JNI Exception checks
• e2254eb: 8316131: runtime/cds/appcds/TestParallelGCWithCDS.java fails with JNI error

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @sendaoYan Pushed as commit 2c9f741.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.